Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't calculate sizes for Box that has Box children #57

Merged

Conversation

saitonakamura
Copy link
Collaborator

Fixes #56

@talentlessguy
Copy link
Member

talentlessguy commented Aug 13, 2021

would like to merge but asking in case, did you test the PR locally?

@saitonakamura
Copy link
Collaborator Author

Yes, I tested it on a case from codesandbox and on the bunch of stories in storybook (I use that PR I've opened). Now that you've mentioned it I also checked the example and it's not working, but it's also not working for me locally in master

@saitonakamura
Copy link
Collaborator Author

Error is

Failed to compile.

./src/index.js
Error: Duplicate plugin/preset detected.
If you'd like to use two separate instances of a plugin,
they need separate names, e.g.

  plugins: [
    ['some-plugin', {}],
    ['some-plugin', {}, 'some unique name'],
  ]

Duplicates detected are:
[
  {
    "alias": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
    "dirname": "/Users/saitonakamura/code/react-three-flex-copy/examples",
    "ownPass": false,
    "file": {
      "request": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
      "resolved": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js"
    }
  },
  {
    "alias": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
    "dirname": "/Users/saitonakamura/code/react-three-flex-copy/examples",
    "ownPass": false,
    "file": {
      "request": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
      "resolved": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js"
    }
  }
]
    at cachedFunction.next (<anonymous>)
^C

when you run yarn start in examples, so I'm pretty sure it's not my changes that broke it

@talentlessguy
Copy link
Member

my bad I've updated react-scripts so this is the cause

@talentlessguy
Copy link
Member

also i'll merge the storybook pr as well

@talentlessguy talentlessguy merged commit b38d737 into pmndrs:master Aug 13, 2021
@talentlessguy
Copy link
Member

done. both pr merged @saitonakamura :P

@saitonakamura
Copy link
Collaborator Author

Yay thanks! This really helps (we're developing a ui for a vr so flex engine is pretty much a must have)

@saitonakamura saitonakamura deleted the fix-nested-boxes-sizes-calc branch August 13, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial bounding box calculation are wrong when using nested boxes
3 participants