refactor(vanilla): split createSnapshot function #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0c64bc9:
|
|
Size Change: +1 B (0%) Total Size: 48.7 kB
ℹ️ View Unchanged
|
7 tasks
dai-shi
added a commit
that referenced
this pull request
Aug 30, 2022
dai-shi
added a commit
that referenced
this pull request
Sep 5, 2022
…dler (#528) * feat(vanilla): unstable_customize instead of unstable_getHandler * unstable_buildProxyFunction * rename to avoid confusion * fix unstable prefix * update docs * expose full features * fix snapshotCache * simplify exposing internal function * a tiny refactor * rever the wrong change in #533 * reorder functions * expose newProxy * revert readme * go back to buildProxyFunction * fix docs * small renaming a param * make shared state global * directly access shared state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small refactor to make #528 easy to review.