Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not use rollup alias #629

Merged
merged 2 commits into from
Jan 15, 2023
Merged

fix(build): do not use rollup alias #629

merged 2 commits into from
Jan 15, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 15, 2023

Just noticed alias is not necessary.
Let's update terser plugin too.

@vercel
Copy link

vercel bot commented Jan 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
valtio ✅ Ready (Inspect) Visit Preview Jan 15, 2023 at 1:43PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ddd9bfc:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

github-actions bot commented Jan 15, 2023

Size Change: 0 B

Total Size: 55.3 kB

ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 710 B
dist/esm/react/utils.js 221 B
dist/esm/utils.js 68 B
dist/esm/vanilla.js 2.27 kB
dist/esm/vanilla/utils.js 4.18 kB
dist/index.js 232 B
dist/macro.js 939 B
dist/macro/vite.js 1.09 kB
dist/react.js 653 B
dist/react/utils.js 237 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 851 B
dist/system/react.production.js 466 B
dist/system/react/utils.development.js 316 B
dist/system/react/utils.production.js 221 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla.development.js 2.4 kB
dist/system/vanilla.production.js 1.45 kB
dist/system/vanilla/utils.development.js 4.4 kB
dist/system/vanilla/utils.production.js 2.92 kB
dist/umd/index.development.js 372 B
dist/umd/index.production.js 322 B
dist/umd/macro.development.js 1.05 kB
dist/umd/macro.production.js 724 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 882 B
dist/umd/react.development.js 797 B
dist/umd/react.production.js 519 B
dist/umd/react/utils.development.js 396 B
dist/umd/react/utils.production.js 297 B
dist/umd/utils.development.js 386 B
dist/umd/utils.production.js 333 B
dist/umd/vanilla.development.js 2.58 kB
dist/umd/vanilla.production.js 1.52 kB
dist/umd/vanilla/utils.development.js 4.66 kB
dist/umd/vanilla/utils.production.js 3 kB
dist/utils.js 236 B
dist/vanilla.js 2.47 kB
dist/vanilla/utils.js 4.51 kB

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented Jan 15, 2023

Just noticed alias is not necessary.

Maybe? The output JS is identical, but *.d.ts import path is changed.

@dai-shi dai-shi changed the title chore: do not use rollup alias fix(build): do not use rollup alias Jan 15, 2023
@dai-shi dai-shi merged commit cad437c into main Jan 15, 2023
@dai-shi dai-shi deleted the chore/no-rollup-alias branch January 15, 2023 14:18
@dai-shi dai-shi mentioned this pull request Feb 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant