Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): bail out with same object assignment #634

Merged
merged 4 commits into from
Feb 4, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 19, 2023

Related Issues

#633

Summary

When setting a property value to a proxy object, it bails out if we are sure that the result is the same. This is done with comparing previous value and new value, but it didn't check the base object. This fixes it.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
valtio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 4, 2023 at 6:16AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b33501b:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

Size Change: +91 B (0%)

Total Size: 55.4 kB

Filename Size Change
dist/esm/vanilla.js 2.29 kB +19 B (+1%)
dist/system/vanilla.development.js 2.42 kB +17 B (+1%)
dist/system/vanilla.production.js 1.46 kB +9 B (+1%)
dist/umd/vanilla.development.js 2.6 kB +17 B (+1%)
dist/umd/vanilla.production.js 1.53 kB +12 B (+1%)
dist/vanilla.js 2.49 kB +17 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 710 B
dist/esm/react/utils.js 221 B
dist/esm/utils.js 68 B
dist/esm/vanilla/utils.js 4.21 kB
dist/index.js 232 B
dist/macro.js 937 B
dist/macro/vite.js 1.09 kB
dist/react.js 652 B
dist/react/utils.js 237 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 851 B
dist/system/react.production.js 466 B
dist/system/react/utils.development.js 316 B
dist/system/react/utils.production.js 221 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla/utils.development.js 4.42 kB
dist/system/vanilla/utils.production.js 2.84 kB
dist/umd/index.development.js 372 B
dist/umd/index.production.js 322 B
dist/umd/macro.development.js 1.05 kB
dist/umd/macro.production.js 724 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 882 B
dist/umd/react.development.js 797 B
dist/umd/react.production.js 519 B
dist/umd/react/utils.development.js 396 B
dist/umd/react/utils.production.js 297 B
dist/umd/utils.development.js 386 B
dist/umd/utils.production.js 333 B
dist/umd/vanilla/utils.development.js 4.7 kB
dist/umd/vanilla/utils.production.js 2.92 kB
dist/utils.js 236 B
dist/vanilla/utils.js 4.54 kB

compressed-size-action

@dai-shi dai-shi merged commit 3fd8623 into main Feb 4, 2023
@dai-shi dai-shi deleted the fix/bail-out-with-same-object branch February 4, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSnapshot parent object has new reference when a child key is assigned to an object
1 participant