fix: set foveation on session reset #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setSession currently reset foveation to 1 https://github.com/mrdoob/three.js/blob/b83bab0b213a0beb7643134021e1e693f1381dcf/src/renderers/webxr/WebXRManager.js#L331 so setFoveation needs to happen after it to work
CodyJasonBennett
changed the title
saitonakamura
added a commit
to mayflower-tech/three.js
that referenced
this pull request
Jan 13, 2023
Currently foveation is set to 1.0 on setSession, and there's no way to set it before, because it's not saved anywere when session is not active. So the only way to set it to a non-default value is to call setSession and call setFoveation afterwards. That leads to hacks in certain scenarios like pmndrs/xr#235. This PR allows setting it beforehand, while being backwards compatible
|
we may not need it after https://github.com/mrdoob/three.js/pull/25282/files |
Mugen87
pushed a commit
to mrdoob/three.js
that referenced
this pull request
Jan 25, 2023
Currently foveation is set to 1.0 on setSession, and there's no way to set it before, because it's not saved anywere when session is not active. So the only way to set it to a non-default value is to call setSession and call setFoveation afterwards. That leads to hacks in certain scenarios like pmndrs/xr#235. This PR allows setting it beforehand, while being backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSession currently reset foveation to 1 https://github.com/mrdoob/three.js/blob/b83bab0b213a0beb7643134021e1e693f1381dcf/src/renderers/webxr/WebXRManager.js#L331 so setFoveation needs to happen after it to work