Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect state change before subscription #164

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 22, 2020

There's an edge case where state is changed between when a hook is used in the render phase and when a hook subscribes to a store in the commit phase.

@dai-shi dai-shi requested a review from drcmda August 22, 2020 23:02
@dai-shi dai-shi merged commit a2547bb into master Aug 26, 2020
@dai-shi dai-shi deleted the fix-detect-state-change-before-subscription branch August 26, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant