fix(build): re-export createStore from index

[hiendv]

Related Issues or Discussions

Fixes #1659

Summary

@barelyhuman forgot to export createStore from the index and it caused a breaking change with code like this (after transpiled to CJS).

// source
import { createStore } from 'zustand'

// cjs result
const zustand_1 = require("zustand");
// Error: zustand_1.createStore is not a function

Check List

• yarn run prettier for formatting code and docs

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 01280b4:

Sandbox	Source
React	Configuration
React Typescript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
@pavlobu/zustand demo	Configuration

[hiendv]

I'm using exports.createStore because of existing vanilla exports.

zustand/src/index.ts

Line 1 in 0b55a3d

export * from './vanilla'

[barelyhuman]

That should've been resolved by the programmatic export but I think that failed for the same reason that the explicit exports were added for.

Thanks for the quick PR!

LGTM

[dai-shi]

That should've been resolved by the programmatic export but I think that failed for the same reason that the explicit exports were added for.

Well, I checked the diff against your build, though.

@barelyhuman I don't think the programmatic solution can resolve this.

[hiendv]

Seems like a problem with module.exports and exports though.
I think we should add E2E tests for this?

Before addModuleExport

exports.create = create;
exports.default = react;
exports.useStore = useStore;
Object.keys(vanilla).forEach(function (k) {
  if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
    enumerable: true,
    get: function () { return vanilla[k]; }
  });
});

After addModuleExport

exports.create = create;
exports.default = react;
exports.useStore = useStore;
Object.keys(vanilla).forEach(function (k) {
  if (k !== 'default' && !exports.hasOwnProperty(k)) Object.defineProperty(exports, k, {
    enumerable: true,
    get: function () { return vanilla[k]; }
  });
});

module.exports = react;
module.exports.create = create;
module.exports.useStore = useStore;
exports.default = module.exports;

[dai-shi]

Nice catch!

[barelyhuman]

That should've been resolved by the programmatic export but I think that failed for the same reason that the explicit exports were added for.
Thanks for the quick PR!
LGTM

Seems like a problem with module.exports and exports though. I think we should add an e2e tests for this?

We do have tests for this...
There's an multi environment and multi node version test in the actions. We'll need bundler specific tests as well which is a very deep hole

[barelyhuman]

That should've been resolved by the programmatic export but I think that failed for the same reason that the explicit exports were added for.

Well, I checked the diff against your build, though.

@barelyhuman I don't think the programmatic solution can resolve this.

Was talking about this at the end of the exports.

My bad though, I forgot this is how the generic module.exports is initialized so...

var module = { exports: {} };
var exports = module.exports;

we replace the entire module.exports so the original exports. one are nullified...

Thanks again to @hiendv for the quick response

[hiendv]

No problem! I was doing a dependency update and noticed nextjs crying so hard lol.

[barelyhuman]

No problem! I was doing a dependency update and noticed nextjs crying so hard lol.

I normally go through the sandboxes to check these, I didn't yesterday and that, backfired.

So again, apologies for anyone who does end up to this issue.