Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow file syntax error #1786

Merged
merged 4 commits into from
May 1, 2023
Merged

fix: workflow file syntax error #1786

merged 4 commits into from
May 1, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented May 1, 2023

there was a mistake in #1678.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8995bda:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
@pavlobu/zustand demo Configuration

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size Change: 0 B

Total Size: 39.9 kB

ℹ️ View Unchanged
Filename Size
dist/context.js 766 B
dist/esm/context.js 572 B
dist/esm/index.js 573 B
dist/esm/middleware.js 3.84 kB
dist/esm/middleware/immer.js 210 B
dist/esm/shallow.js 509 B
dist/esm/vanilla.js 629 B
dist/index.js 725 B
dist/middleware.js 4.41 kB
dist/middleware/immer.js 328 B
dist/shallow.js 1.11 kB
dist/system/context.development.js 680 B
dist/system/context.production.js 365 B
dist/system/index.development.js 735 B
dist/system/index.production.js 402 B
dist/system/middleware.development.js 3.97 kB
dist/system/middleware.production.js 2.6 kB
dist/system/middleware/immer.development.js 292 B
dist/system/middleware/immer.production.js 187 B
dist/system/shallow.development.js 558 B
dist/system/shallow.production.js 344 B
dist/system/vanilla.development.js 672 B
dist/system/vanilla.production.js 310 B
dist/umd/context.development.js 868 B
dist/umd/context.production.js 533 B
dist/umd/index.development.js 855 B
dist/umd/index.production.js 533 B
dist/umd/middleware.development.js 4.56 kB
dist/umd/middleware.production.js 2.95 kB
dist/umd/middleware/immer.development.js 482 B
dist/umd/middleware/immer.production.js 342 B
dist/umd/shallow.development.js 1.23 kB
dist/umd/shallow.production.js 883 B
dist/umd/vanilla.development.js 800 B
dist/umd/vanilla.production.js 410 B
dist/vanilla.js 683 B

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented May 1, 2023

@arjunvegda My bad, we didn't solve the NODE_ENV issue.

@arjunvegda
Copy link
Collaborator

@arjunvegda My bad, we didn't solve the NODE_ENV issue.

All good! It doesn't appear to be a problem actually. All the tests for the vitest PR are now passing.

@dai-shi
Copy link
Member Author

dai-shi commented May 1, 2023

@arjunvegda No, it's a syntax error: https://github.com/pmndrs/zustand/actions/runs/4855258105

@dai-shi dai-shi requested a review from arjunvegda May 1, 2023 22:11
@dai-shi
Copy link
Member Author

dai-shi commented May 1, 2023

@arjunvegda ended up copying for DEV/PRD.

@dai-shi dai-shi changed the title fix workflow file format fix: workflow file syntax error May 1, 2023
@arjunvegda
Copy link
Collaborator

@arjunvegda ended up copying for DEV/PRD.

yeah, seems like a good workaround for now!

@dai-shi dai-shi merged commit 1808bf4 into main May 1, 2023
@dai-shi dai-shi deleted the fix/github-workflow branch May 1, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants