-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Do not recommend deprecated useStore + equalityFn on initialize with props docs #1997
fix(docs): Do not recommend deprecated useStore + equalityFn on initialize with props docs #1997
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 51af424:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, maybe we should show both? because some people don't use equalityFn
.
I agree, and I'd say that most people don't use |
Sure! I updated the content, how does it sound? |
Co-authored-by: Blazej Sewera <code@sewera.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Please run prettier.
Done! Sorry not noticing it earlier. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zustand](https://github.com/pmndrs/zustand) | [`4.4.1` -> `4.4.6`](https://renovatebot.com/diffs/npm/zustand/4.4.1/4.4.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/zustand/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zustand/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zustand/4.4.1/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zustand/4.4.1/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/zustand (zustand)</summary> ### [`v4.4.6`](https://github.com/pmndrs/zustand/releases/tag/v4.4.6) [Compare Source](https://github.com/pmndrs/zustand/compare/v4.4.5...v4.4.6) v4.4.5 has an issue with some TypeScript configs about module resolution. It should be fixed now. Thanks for the patience. #### What's Changed - Update export types by [@​dbritto-dev](https://github.com/dbritto-dev) in [https://github.com/pmndrs/zustand/pull/2170](https://github.com/pmndrs/zustand/pull/2170) #### New Contributors - [@​cheatkey](https://github.com/cheatkey) made their first contribution in [https://github.com/pmndrs/zustand/pull/2147](https://github.com/pmndrs/zustand/pull/2147) - [@​frixaco](https://github.com/frixaco) made their first contribution in [https://github.com/pmndrs/zustand/pull/2166](https://github.com/pmndrs/zustand/pull/2166) **Full Changelog**: pmndrs/zustand@v4.4.5...v4.4.6 ### [`v4.4.5`](https://github.com/pmndrs/zustand/releases/tag/v4.4.5) [Compare Source](https://github.com/pmndrs/zustand/compare/v4.4.4...v4.4.5) Hopefully, it should fix some issues with Node.js environment including Next.js. #### What's Changed - fix: importing CJS React in ESM by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/zustand/pull/2154](https://github.com/pmndrs/zustand/pull/2154) - Apply publint recommendations by [@​dbritto-dev](https://github.com/dbritto-dev) in [https://github.com/pmndrs/zustand/pull/2157](https://github.com/pmndrs/zustand/pull/2157) #### New Contributors - [@​plrs9816](https://github.com/plrs9816) made their first contribution in [https://github.com/pmndrs/zustand/pull/2137](https://github.com/pmndrs/zustand/pull/2137) - [@​Brammm](https://github.com/Brammm) made their first contribution in [https://github.com/pmndrs/zustand/pull/2139](https://github.com/pmndrs/zustand/pull/2139) - [@​sobies93](https://github.com/sobies93) made their first contribution in [https://github.com/pmndrs/zustand/pull/2142](https://github.com/pmndrs/zustand/pull/2142) **Full Changelog**: pmndrs/zustand@v4.4.4...v4.4.5 ### [`v4.4.4`](https://github.com/pmndrs/zustand/releases/tag/v4.4.4) [Compare Source](https://github.com/pmndrs/zustand/compare/v4.4.3...v4.4.4) There was a tiny issue in v4.4.3, which broke with some bundlers, which this version fixes. #### What's Changed - fix(build): patch entry points zustand/shallow for CJS by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/zustand/pull/2128](https://github.com/pmndrs/zustand/pull/2128) **Full Changelog**: pmndrs/zustand@v4.4.3...v4.4.4 ### [`v4.4.3`](https://github.com/pmndrs/zustand/releases/tag/v4.4.3) [Compare Source](https://github.com/pmndrs/zustand/compare/v4.4.2...v4.4.3) The changes in v4.4.2 were troublesome for some users. This version should fix/mitigate such cases. #### What's Changed - fix(shallow): Extract shallow vanilla and react by [@​dbritto-dev](https://github.com/dbritto-dev) in [https://github.com/pmndrs/zustand/pull/2097](https://github.com/pmndrs/zustand/pull/2097) - fix(types): mitigate devtools typing by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/zustand/pull/2099](https://github.com/pmndrs/zustand/pull/2099) **Full Changelog**: pmndrs/zustand@v4.4.2...v4.4.3 ### [`v4.4.2`](https://github.com/pmndrs/zustand/releases/tag/v4.4.2) [Compare Source](https://github.com/pmndrs/zustand/compare/v4.4.1...v4.4.2) This adds `useShallow` hook to cover some use cases that are deprecated with v4.4.0 change. Check out [the guide](https://github.com/pmndrs/zustand/blob/ec538e9d4c0b9b5759e6dfd0fd3c9a21f8236949/docs/guides/prevent-rerenders-with-use-shallow.md). ##### Migration Guide [#​1991](https://github.com/pmndrs/zustand/issues/1991) requires something like below if you are using the `devtools` middleware *and* TypeScript. ```diff import { devtools } from 'zustand/middleware' + import type {} from '@​redux-devtools/extension' ``` ##### What's Changed - fix(types)(middleware/devtools): avoid copying types by [@​dai-shi](https://github.com/dai-shi) in [https://github.com/pmndrs/zustand/pull/1991](https://github.com/pmndrs/zustand/pull/1991) - fix(traditional): make defaultEqualityFn optional in TS Types by [@​charkour](https://github.com/charkour) in [https://github.com/pmndrs/zustand/pull/2060](https://github.com/pmndrs/zustand/pull/2060) - feat: add useShallow by [@​FaberVitale](https://github.com/FaberVitale) in [https://github.com/pmndrs/zustand/pull/2090](https://github.com/pmndrs/zustand/pull/2090) ##### New Contributors - [@​aykutkardas](https://github.com/aykutkardas) made their first contribution in [https://github.com/pmndrs/zustand/pull/1993](https://github.com/pmndrs/zustand/pull/1993) - [@​michelts](https://github.com/michelts) made their first contribution in [https://github.com/pmndrs/zustand/pull/1997](https://github.com/pmndrs/zustand/pull/1997) - [@​elusive](https://github.com/elusive) made their first contribution in [https://github.com/pmndrs/zustand/pull/2001](https://github.com/pmndrs/zustand/pull/2001) - [@​mayank1513](https://github.com/mayank1513) made their first contribution in [https://github.com/pmndrs/zustand/pull/2015](https://github.com/pmndrs/zustand/pull/2015) - [@​fdb](https://github.com/fdb) made their first contribution in [https://github.com/pmndrs/zustand/pull/2029](https://github.com/pmndrs/zustand/pull/2029) - [@​tmkx](https://github.com/tmkx) made their first contribution in [https://github.com/pmndrs/zustand/pull/2032](https://github.com/pmndrs/zustand/pull/2032) - [@​OshriAsulin](https://github.com/OshriAsulin) made their first contribution in [https://github.com/pmndrs/zustand/pull/2028](https://github.com/pmndrs/zustand/pull/2028) - [@​ivanquirino](https://github.com/ivanquirino) made their first contribution in [https://github.com/pmndrs/zustand/pull/2047](https://github.com/pmndrs/zustand/pull/2047) - [@​stavkamil](https://github.com/stavkamil) made their first contribution in [https://github.com/pmndrs/zustand/pull/2071](https://github.com/pmndrs/zustand/pull/2071) - [@​NaamuKim](https://github.com/NaamuKim) made their first contribution in [https://github.com/pmndrs/zustand/pull/2088](https://github.com/pmndrs/zustand/pull/2088) - [@​FaberVitale](https://github.com/FaberVitale) made their first contribution in [https://github.com/pmndrs/zustand/pull/2090](https://github.com/pmndrs/zustand/pull/2090) **Full Changelog**: pmndrs/zustand@v4.4.1...v4.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Summary
Passing an equalityFn to the useStore hook is deprecated. The documentation to initialize the store from props is recommending the approach. It was updated to recommend using useStoreWithEqualityFn instead.
Check List
yarn run prettier
for formatting code and docsBTW notice running prettier messed with a lot of files but didn't change the file I changed. I'm not pushing those other files formatting changes though.