-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix devtools warning in CLI #2404
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
What's the problem of showing the warning? If it doesn't help much, we should remove it entirely. |
It makes no sense to show a warning related to a browser extension in the node console. I don't think it's wrong to show it in the browser (redux does it, right?). I just don't want that message to show in my console every time Next.js renders a page. |
Well, you don't need to use the middleware technically.
Does anyone else have good experience with the message in the browser? |
I forgot that our solution provided now is Please specify |
But how does it make sense to check for a browser plugin when there's no browser? Before the |
I think we should consider removing the warning entirely, if the current solution doesn't fit well. |
Related Issues or Discussions
n/a
Summary
The warning always shows in the CLI. This fixes it.