Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shallow): fallback map-like iterator comparison #2795

Merged
merged 3 commits into from
Oct 27, 2024
Merged

fix(shallow): fallback map-like iterator comparison #2795

merged 3 commits into from
Oct 27, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 16, 2024

Related Bug Reports or Discussions

Fixes #2794

Summary

There is a logic to guess map-like iterator but it's not perfect. This adds fallback.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 7:37am

Copy link

codesandbox-ci bot commented Oct 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Oct 16, 2024

Size Change: +36 B (+0.3%)

Total Size: 12 kB

Filename Size Change
./dist/esm/vanilla/shallow.mjs 567 B +17 B (+3.09%)
./dist/vanilla/shallow.js 581 B +19 B (+3.38%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.56 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/react.mjs 320 B
./dist/esm/react/shallow.mjs 193 B
./dist/esm/shallow.mjs 82 B
./dist/esm/traditional.mjs 411 B
./dist/esm/vanilla.mjs 403 B
./dist/index.js 244 B
./dist/middleware.js 3.56 kB
./dist/middleware/immer.js 229 B
./dist/react.js 336 B
./dist/react/shallow.js 208 B
./dist/shallow.js 189 B
./dist/traditional.js 423 B
./dist/vanilla.js 416 B

compressed-size-action

@dai-shi dai-shi merged commit 259c19f into main Oct 27, 2024
26 checks passed
@dai-shi dai-shi added this to the v5.0.1 milestone Oct 27, 2024
@dai-shi dai-shi deleted the bug-2794 branch October 27, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant