Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTING.md): change 'pnpm' to 'pnpm install' for installing dependencies #2890

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 10, 2024

Summary

  • The correct command is not pnpm but pnpm install

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:50am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dbritto-dev
Copy link
Collaborator

Same as yarn install, you can use yarn or yarn install

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 10, 2024

image

@dbritto-dev but we are using pnpm not yarn, yarn is right command to install dependencies but pnpm is wrong. if we want it, we have to write pnpm install or pnpm i.

@dbritto-dev dbritto-dev reopened this Dec 10, 2024
@dbritto-dev
Copy link
Collaborator

@sukvvon in that case looks good to me, let me merge it

@dbritto-dev dbritto-dev merged commit 3fdf3c9 into pmndrs:main Dec 10, 2024
27 checks passed
@sukvvon sukvvon deleted the docs/contributing branch December 10, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants