Skip to content

Commit

Permalink
Merge pull request #22 from pmonks/dev
Browse files Browse the repository at this point in the history
Release 2.0.233
  • Loading branch information
pmonks authored Jun 27, 2024
2 parents fa85588 + d8ede8d commit 4c94dce
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
with:
distribution: 'temurin'
java-version: ${{ matrix.java-version }}
- uses: DeLaGuardo/setup-clojure@12.1
- uses: DeLaGuardo/setup-clojure@12.5
with:
cli: latest
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.m2/repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
with:
distribution: 'temurin'
java-version: 21
- uses: DeLaGuardo/setup-clojure@12.1
- uses: DeLaGuardo/setup-clojure@12.5
with:
cli: latest
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.m2/repository
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
distribution: 'temurin'
java-version: 21
- uses: DeLaGuardo/setup-clojure@12.1
- uses: DeLaGuardo/setup-clojure@12.5
with:
cli: latest
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.m2/repository
Expand All @@ -30,7 +30,7 @@ jobs:
run: clojure -Srepro -J-Dclojure.main.report=stderr -T:build docs

- name: Deploy docs
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./target/doc
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,10 @@ Note that using Unicode characters in progress indicators may be unreliable, dep

2. If you're using the Clojure CLI tools, you **must** use the `clojure` binary, as the `clj` binary wraps the JVM in `rlwrap` which then incorrectly interprets some of the ANSI escape sequences emitted by `spinner`. Some other readline alternatives (notably [Rebel Readline](https://github.com/bhauman/rebel-readline)) have been reported to work correctly.

#### deps-try

Doesn't work properly, for the same reason the `clj` command line doesn't work properly (`rlwrap` intercepts the ANSI escape sequences emitted by this library and misinterprets them).

#### Clojure CLI

```shell
$ clojure -Sdeps '{:deps {com.github.pmonks/spinner {:mvn/version "#.#.#"}}}' # Where #.#.# is replaced with an actual version number (see badge above)
$ clojure -Sdeps '{:deps {com.github.pmonks/spinner {:mvn/version "RELEASE"}}}'
```

#### Leiningen
Expand All @@ -48,6 +44,10 @@ $ clojure -Sdeps '{:deps {com.github.pmonks/spinner {:mvn/version "#.#.#"}}}' #
$ lein trampoline try com.github.pmonks/spinner
```

#### deps-try

Doesn't work properly, for the same reason the `clj` command line doesn't work properly (`rlwrap` intercepts the ANSI escape sequences emitted by this library and misinterprets them).

#### Simple REPL Session

##### Indeterminate Task (aka "spinner")
Expand Down
2 changes: 1 addition & 1 deletion pbr.clj
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
:validate-pom true
:pom {:description "Simple ANSI text progress indicators for command line Clojure apps."
:url "https://github.com/pmonks/spinner"
:licenses [:license {:name "Apache License 2.0" :url "http://www.apache.org/licenses/LICENSE-2.0.html"}]
:licenses [:license {:name "Apache-2.0" :url "http://www.apache.org/licenses/LICENSE-2.0.html"}]
:developers [:developer {:id "pmonks" :name "Peter Monks" :email "pmonks+spinner@gmail.com"}]
:scm {:url "https://github.com/pmonks/spinner" :connection "scm:git:git://github.com/pmonks/spinner.git" :developer-connection "scm:git:ssh://git@github.com/pmonks/spinner.git"}
:issue-management {:system "github" :url "https://github.com/pmonks/spinner/issues"}}))
1 change: 1 addition & 0 deletions src/progress/determinate.clj
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ opts is a map, optionally containing these keys:
(ansi/save-cursor!)
(jansi/cursor! 1 line))
(print "\r")
(jansi/erase-line!)
(when line (ansi/restore-cursor!))))
(flush))))))))

Expand Down

0 comments on commit 4c94dce

Please sign in to comment.