Support for New Semantic Release Version and Node 18 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4rlock
changed the title
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
May 3, 2023
Use temporary forks with pmowrer/semantic-release-monorepo#137 and pmowrer/semantic-release-plugin-decorators#31 applied to work around pmowrer/semantic-release-monorepo#136
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
May 3, 2023
Use temporary forks with pmowrer/semantic-release-monorepo#137 and pmowrer/semantic-release-plugin-decorators#31 applied to work around pmowrer/semantic-release-monorepo#136
|
@pmowrer I'd really appreciate if you could have a look at this soon, as the esm error blocks me from upgrading to semantic-release v21. |
|
@pmowrer Same issue here |
|
@w4rlock Maybe you could focus your changes to the bare minimum of what we want to achieve here (compatibility with semantic v21 + node 18) and leave out all the rest (eslint/prettier stuff, moving from yarn to npm, etc.), so this becomes easier to review... |
|
Hi, any updates? |
1 similar comment
|
Hi, any updates? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please
I need to merge theses changes.
Theses changes resolve next error (ERR_REQUIRED_ESM)