Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CICP Chunk described in PNG 3rd Edition (Priority 1) #508

Open
digitaltvguy opened this issue Dec 23, 2023 · 9 comments
Open

Implement CICP Chunk described in PNG 3rd Edition (Priority 1) #508

digitaltvguy opened this issue Dec 23, 2023 · 9 comments

Comments

@digitaltvguy
Copy link

The CICP Chunk identifies explicit characteristics of an image which is described in H.273. CICP is used in every video wrapper and in many codecs to identify the images contained in every framer.

Without this HDR/SDR/WCG (High Dynamic Range, Standard Dynamic Range and Wide Color Gamut) images using BT.709, BT.2100 can't be identified properly.

Identification is critical for content creation described in ITU-R BT.2408 (single-master UHD workflows). The new CICP chunk gives new support for

@jbowler
Copy link
Contributor

jbowler commented Dec 23, 2023

Spamming the issues list seems inappropriate.

@digitaltvguy
Copy link
Author

digitaltvguy commented Dec 23, 2023 via email

@jbowler
Copy link
Contributor

jbowler commented Dec 23, 2023

How can I help?

Do what I suggested to Chris Blume (@programmax) - submit a pull request.

@digitaltvguy
Copy link
Author

digitaltvguy commented Dec 23, 2023 via email

@jbowler
Copy link
Contributor

jbowler commented Dec 23, 2023

Well, ok. Don't respond from your inbox: go to github.com and enter responses there.

@digitaltvguy
Copy link
Author

digitaltvguy commented Dec 23, 2023

We're looking for help from this community in translating the functions of the cICP chunk described in PNG 3rd Edition to libping.

Here is the temporary location for our conformance files with the new chunks:

https://www.dropbox.com/scl/fo/a44vfxw3p21kvkh8nywpc/h?rlkey=v63ekq5y49kd4omg59ng9q3zr&dl=0

Here is PNG 3rd Edition: https://www.w3.org/TR/png-3/

@jbowler
Copy link
Contributor

jbowler commented Dec 23, 2023

I'll say it exactly this once more.

There is real work to be done here. You; you personally, need to do it. There's no one else here.

@svgeesus
Copy link

See #565

@jbowler
Copy link
Contributor

jbowler commented Jul 17, 2024

Exactly, and @LucasChollet stepped up. Even better his pull request demonstrates an ability to deal with the actual build process and an understanding of the basic architecture. His patch was as good as one I might have contributed in another world and, perhaps, better because I'm sure he is approaching it with a less jaundiced mind. To be clear; he did the things I would have done well just as well and the errors he made were certainly those I might have made (though we would probably have made different errors in practice of course.)

I suggest to @LucasChollet and @ctruta that you talk directly to each other about what you are each trying to achieve. I suggest not on 565. I suggest to @ctruta that you need someone else on this and that someone is not me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants