Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair of CVE-2019-6129 #269 and issue #255 #294

Closed
wants to merge 2 commits into from
Closed

Repair of CVE-2019-6129 #269 and issue #255 #294

wants to merge 2 commits into from

Conversation

tangyaofang
Copy link
Contributor

Repair of CVE-2019-6129 #269 and issue #255

This was referenced Nov 16, 2022
Closed
Closed
ctruta
ctruta reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@ctruta ctruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not actually fix the underlying problem. It merely moves it from one place to another, and it is still dependent on the specific compiler behaviour.

@ctruta
Copy link
Member

ctruta commented Nov 28, 2022

I am closing this pull request, and discussing the proper solution with @jbowler in issue #255.

@ctruta ctruta closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctruta ctruta ctruta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangyaofang @ctruta