Refactor cycling degradation calculation for unitary DX equipment #105
Conversation
| part_eff_ref_std="ahri_340/360", | ||
| part_eff_ref_std_alt=None, | ||
| model="simplified_bf", | ||
| sim_engine="energyplus", | ||
| condenser_type="air", | ||
| fan_control_mode="constant_speed", | ||
| degradation_coefficient=0.115170535550221, # plf = (1 - C_D) * C_D * plr in AHRI 240/210 |
There was a problem hiding this comment.
This value is equivalent to the default in AHRI 340/360.
There was a problem hiding this comment.
Based on a review of the CEC appliance database that we did a couple year back we had seen an average value of 0.08. EnergyPlus' default is 0.2. We can document all of that.
There was a problem hiding this comment.
So, should we add a choice for the users here, like "d_f" as for 0.08, 0.2, or 0.115?
There was a problem hiding this comment.
Yes, that's what it is, except that it's fully spelled out, and the default value is the same as what's used by default in AHRI 340/360: C_D = 1.130 - 0.130 * LF. You can see that by seeing that the test you wrote that calculates IEER passes.
| self.degradation_coefficient = degradation_coefficient | ||
| if not "plf_f_plr" in self.get_dx_curves().keys(): | ||
| plf_f_plr = Curve(eqp=self, c_type="linear") | ||
| plf_f_plr.out_var = "plf-f-plr" | ||
| plf_f_plr.type = "linear" | ||
| plf_f_plr.coeff1 = 1 - self.degradation_coefficient | ||
| plf_f_plr.coeff2 = self.degradation_coefficient | ||
| plf_f_plr.x_min = 0 | ||
| plf_f_plr.x_max = 1 | ||
| plf_f_plr.out_min = 0 | ||
| plf_f_plr.out_max = 1 | ||
| self.set_of_curves.append(plf_f_plr) |
There was a problem hiding this comment.
Add a curve based on the user-defined or default degradation coefficient.
There was a problem hiding this comment.
em, so add this curve here to calculate d_c?
| }, | ||
| "plf-f-plr": { | ||
| "out_var": "plf-f-plr", | ||
| "type": "quad", | ||
| "coeff1": 0, | ||
| "coeff2": 0, | ||
| "coeff3": 1.0, | ||
| "x_min": 0.0, | ||
| "x_max": 1.0, | ||
| "out_min": null, | ||
| "out_max": null, | ||
| "ref_ect": 35, | ||
| "units": "si" |
There was a problem hiding this comment.
These defaults are not needed anymore since we handle it at the initialization.
There was a problem hiding this comment.
Ask Aowabin to remove these from his current curves as well?
There was a problem hiding this comment.
And, we should remove all "plf-f-plr" from the jason file?
There was a problem hiding this comment.
All the ones that we added as defaults, yes. @aowabinr - FYI.
Refactor cycling degradation calculation for unitary DX equipment by using a default
C_dof degradation coefficient.