Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to generate aggregate DX curves #113

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Updates to generate aggregate DX curves #113

merged 6 commits into from
Sep 16, 2024

Conversation

aowabinr
Copy link
Collaborator

@aowabinr aowabinr commented Sep 14, 2024

Updates for generating aggregated curves for DX (wt-avg and nn-wt-avg):

  • Changing ref_cap as var_name -> ref_gross_cap
  • accommodating additional out_vars (i.e. eir-f-ff and cap-ff)
  • changing threshold for compute_grad (i.e. tolerance on how much we can accept anomalous gradients) changed from 1e-5 to 0.02.

test_dx

Note: In the future we need to make target variables for computing the weighted average (ref_gross_cap, part_eff, full_eff) as input arguments to SetofCurves class

Copy link
Collaborator

@lymereJ lymereJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were failings, I had to make some changes. @aowabinr - please review and merge if that looks good to you.

@lymereJ lymereJ merged commit 3bd4d98 into develop Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants