Skip to content

Commit

Permalink
Ensure that for first party web parts that support full bleed we set …
Browse files Browse the repository at this point in the history
…the SupportsFullBleed flag #1554
  • Loading branch information
jansenbe committed Nov 18, 2024
1 parent 1642df9 commit 45c546e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Pages that removed the full width section and the banner web part and therefore have no page title anymore do not get a page title when being updated #1550 [jansenbe - Bert Jansen]
- Fixed regression introduced by https://github.com/pnp/pnpcore/commit/29a64bef0cfedbb3a0f7b64386b64d54793d7d71 and was partly fixed by #1577 [jansenbe - Bert Jansen]
- Improved page parsing robustness by allowing zone and section index values to be not defined #1552 [jansenbe - Bert Jansen]
- Ensure that for first party web parts that support full bleed we set the SupportsFullBleed flag #1554 [jansenbe - Bert Jansen]

## [1.14]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,13 @@ internal override void FromHtml(IElement element, bool isHeader)
{
SupportsFullBleed = isFullWidth.GetBoolean();
}
else if (Page.IdToDefaultWebPart(WebPartId) == DefaultWebPart.PageTitle)
// Ensure that for first party web parts that support full bleed we set the SupportsFullBleed flag
else if (Page.IdToDefaultWebPart(WebPartId) == DefaultWebPart.PageTitle || //Message ID: MC791596 / Roadmap ID: 386904
Page.IdToDefaultWebPart(WebPartId) == DefaultWebPart.Image ||
Page.IdToDefaultWebPart(WebPartId) == DefaultWebPart.Hero ||
Page.IdToDefaultWebPart(WebPartId) == DefaultWebPart.CountDown)
{
SupportsFullBleed = true; //Message ID: MC791596 / Roadmap ID: 386904
SupportsFullBleed = true;
}
}

Expand Down

0 comments on commit 45c546e

Please sign in to comment.