AddLabelAndDescription of a Term throws "PnP.Core.ClientException: Property Id was not yet loaded"

[JuergenRB]

Category

• Bug

Describe the bug

When trying to set the label for an existing term, an error occurs.

PnP.Core.ClientError
PnP.Core.ClientException: Property Id was not yet loaded
   at PnP.Core.Model.TransientObject.GetValue[T](String propertyName)
   at PnP.Core.Model.SharePoint.TermSet.get_Id()
   at PnP.Core.Model.SharePoint.Term.OverrideUpdateOrDeleteApiCall(ApiCallRequest apiCallRequest)
   at PnP.Core.Model.SharePoint.Term.<.ctor>b__2_4(ApiCallRequest apiCallRequest)
   at PnP.Core.Services.QueryClient.BuildUpdateAPICallGraphAsync[TModel](BaseDataModel`1 model, EntityInfo entity, Boolean viaBatchMethod)
   at PnP.Core.Services.QueryClient.BuildUpdateAPICallAsync[TModel](BaseDataModel`1 model, EntityInfo entity, Boolean viaBatchMethod)
   at PnP.Core.Model.BaseDataModel`1.BaseUpdate(Func`2 fromJsonCasting, Action`1 postMappingJson)
   at PnP.Core.Model.BaseDataModel`1.UpdateAsync()

Steps to reproduce

Proceed as described in the documentation

var newTerm = await termStore.GetTermByIdAsync(termSetId, termId, t => t.Labels, t => t.Id);
// Add a new term label for language fr-FR
// Note: fr-FR must be a language allowed in the term store
newTerm.AddLabelAndDescription("French label", "fr-FR");
await newTerm.UpdateAsync();

Expected behavior

Updates the label without error

[jansenbe]

@JuergenRB : this indeed fails, it's however a harder problem to tackle. In short when using this method the underlying graph call gets a term, but there's no information about it's parent. When it's a top level term the termset of the term can be requested, but when it's a child term the term's parent is another term and in Graph there's no support for getting the parent of a term. I'm evaluating whether I can plug-in a CSOM call (as there's a Term.Parent in CSOM) to workaround.

A workaround for now can be to load the term by traversing the termset

[JuergenRB]

Thanks for your effort, I am curious about the final implementation.
And thanks for the tip, I will test it with the traversing.

[jansenbe]

@JuergenRB : a fix has been pushed, you can try this with the next nightly. Closing this issue now, please re-open or create a new one in case things still don't work for you.

[JuergenRB]

@jansenbe: I was able to test now with nightly 1.9.68 - I get a different error for the GetTermByIdAsync method

I just find it strange, because in my code the DefaultLanguage was definitely loaded for the TermStore.
And it happens with SubTerms (2 Level Term of a TermSet): Group > TermSet > Term > (Sub-)Term

The 1 Level childs of TermSets do not have the issue.

[jansenbe]

@JuergenRB : the DefaultLanguage property was used in a place while it was not sure it was loaded, so I've added an context.TermStore.EnsurePropertiesAsync(p => p.DefaultLanguage); line. However, if you've loaded DefaultLanguage for the context you are using this error should not happen. So try again with next nightly or alternatively ensure you've loaded the TermStore.DefaultLanguage before calling GetTermById.