Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich metadata model to describe supported functionalities #38

Closed
PaoloPia opened this issue May 20, 2020 · 4 comments
Closed

Enrich metadata model to describe supported functionalities #38

PaoloPia opened this issue May 20, 2020 · 4 comments
Assignees
Labels

Comments

@PaoloPia
Copy link
Contributor

Make it possible to mark domain model types, properties, and method with requirements (from a security point of view: delegated, app-only, both) and with OData support (like: $select, $filter, $orderby, $top, $skip, $expand, etc.).

@jansenbe
Copy link
Contributor

jansenbe commented Sep 8, 2020

$select/$expand typically works (we could tap into https://github.com/microsoftgraph/msgraph-metadata). $filter and $orderby are more complex ones as some fields work with $filter, some don't.

Required permissions can be fetched from https://github.com/microsoftgraph/msgraph-metadata as well

@jansenbe
Copy link
Contributor

Some additional thoughts:

  • For $filter then should also define which filter operators work (or which don't)
  • Also included metadata to define in app-only (read/write) is supported or not

@jansenbe jansenbe added this to the Beta 1 milestone Sep 28, 2020
@jansenbe
Copy link
Contributor

jansenbe commented Oct 1, 2020

TestQueryTeamChannelMessages fails due to $top being added while it's not supported

@jansenbe
Copy link
Contributor

Closing this one: a ton of work and the added value will be just cleaner error messages in case of a mission permission or wrongly used query parameter. Also checking on query parameters like $filter is not so obvious, in graph one can filter on some fields but not on all...there's no easy way to understand which fields are filterable and having a check in PnP Core SDK would then mean we always have to keep maintaining this metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants