Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamChannel.GetByDisplayName does not work as $top=1 is not valid in the Graph query #198

Closed
1 task done
jansenbe opened this issue Oct 19, 2020 · 2 comments
Closed
1 task done
Assignees
Labels
area: linq 🧝‍♂️ LINQ magic bug Something isn't working

Comments

@jansenbe
Copy link
Contributor

Category

  • Bug

Describe the bug

GetByDisplayName constructs a query like /teams/b32780e9-df70-4548-a735-4e7f055415a1/channels?$filter=displayName eq 'General'&$top=1 which does not work. Leaving $top out works in this case.

Related to #38

@jansenbe jansenbe added the bug Something isn't working label Oct 19, 2020
@jansenbe jansenbe added this to the Beta 1 milestone Oct 19, 2020
@jansenbe jansenbe self-assigned this Oct 19, 2020
jansenbe added a commit that referenced this issue Oct 19, 2020
@jansenbe jansenbe modified the milestones: Beta 1, Beta 2 Dec 7, 2020
@jansenbe jansenbe removed this from the Beta 2 milestone Dec 10, 2020
@pkbullock
Copy link
Collaborator

pkbullock commented Dec 18, 2020

From testing this issue only affect Async e.g. (GetByDisplayNameAsync) calls. There must be a reasonable difference there - or an indication the non-async calls under hood is missing something making this by chance a working call.

@jansenbe
Copy link
Contributor Author

jansenbe commented Jan 3, 2021

Both were using different implementations in this case, with the new series of Get methods on collections and the rewrite of the GetBy... methods to use those new collection get methods this issue has been resolved.

@jansenbe jansenbe closed this as completed Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: linq 🧝‍♂️ LINQ magic bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants