Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieves "Everyone except external users" login. Closes #1125 #1127

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

plamber
Copy link
Contributor

@plamber plamber commented Mar 4, 2023

Closes #1125

@plamber
Copy link
Contributor Author

plamber commented Mar 4, 2023

I am not sure how to test the tenantId usecase in this environment. Therefore, that if statement is uncovered

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.84 🎉

Comparison is base (63545f3) 82.42% compared to head (3082217) 84.26%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1127      +/-   ##
==========================================
+ Coverage   82.42%   84.26%   +1.84%     
==========================================
  Files         416      610     +194     
  Lines       28590    41675   +13085     
==========================================
+ Hits        23565    35119   +11554     
- Misses       5025     6556    +1531     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 43.90% <0.00%> (-18.17%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 53.19% <0.00%> (-14.71%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 81.60% <0.00%> (-11.25%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
... and 321 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jansenbe jansenbe merged commit 3082217 into pnp:dev Mar 4, 2023
jansenbe added a commit that referenced this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve the "Everyone except external users" login
3 participants