Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new commandlet, Get-PnPExpiringMicrosoft365Groups #2466

Merged
merged 6 commits into from
Oct 15, 2022

Conversation

koskila
Copy link
Contributor

@koskila koskila commented Oct 14, 2022

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

None.

What is in this Pull Request ?

This PR adds new commandlet, Get-PnPExpiringMicrosoft365Groups. By default, it'll return groups expiring in the next 31 days (to be in line with SharePoint/OneDrive's retention period's 31-day months), but this can be changed by supplying a value to -Limit parameter.

I had to pass the additionalheaders to a few places to enable "advanced query capabilities", but I tried to comment that in the code to make it clear why.

Guidance

  • You can delete this section when you are submitting the pull request.*
  • Please update this PR information accordingly. We use this as part of our release notes in monthly communications.
  • Please target your PR to Dev branch. If you do not target the Dev branch we will not accept this PR.

@gautamdsheth
Copy link
Collaborator

Awesome stuff @koskila, really glad to have you contributing here 🙏😊

Couple of things:

  1. Can you please use singular, i.e rename it to Get-PnPMicrosoft365ExpiringGroup? It is a PowerShell convention. I know it's a bit weird, but that's how it is :(

  2. Can you also please add the documentation for this? You can create a Get-PnPMicrosoft365ExpiringGroup.md file inside the documentation folder. You can check other docs for example.

@gautamdsheth gautamdsheth merged commit c555289 into pnp:dev Oct 15, 2022
@gautamdsheth
Copy link
Collaborator

Thank you @koskila, have merged it !!

@koskila koskila deleted the feature/expiringgroups branch October 16, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants