Fix - Check the UniqueId column instead of GUID column #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have to watch out with this one... it's quite a breaking change as such that is easily missed, especially in the context of scripts to be migrated. I'll give it some thought. |
|
Why not modify the CAML query to use an or? E.g. check for both UniqueID or GUID value. As they're unique anyway, there will be no risk of conflicts that you find the wrong item. |
|
Haa :) , makes perfect sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
What is in this Pull Request ?
Currently we filtering based on the GUID column instead of the UniqueId column.
This PR fixes that. Used to cause confusion
Please credit the original author if we merge this :)