-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RichText] - Problem with edit mode #445
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Hi @PooLP! I've committed the fix. |
After test, it's ok for me. PS :
Do we need to do something more (run on docker an env with 1.3.0 spfx version of generator, specific version of VSC ...) ? |
Thanks, I will do that! ^^ |
Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
spfx : 1.9.1
sp-dev-fx-controls-react : 1.16
Sharepoint OnLine : Targeted and Standard release
Chrome/Edge : latest version
Windows 10 : latest version
Expected / Desired Behavior / Question
The edit mode don't work anymore
Observed Behavior
I'm use a richText editor in a WebPart to edit a simple introduction text. in edit mode, the richText do not switch to edit.
The problem started last week, and I didn't do any component-side updates (no update, the webpart was already installed and worked very well).
I updated to PnP SPFx Control 1.16, but I still have the problem.
I have tested on Chrome and Edge latest version with same problem.
I have tested with React DevTools. The condition pass a "isEditMode" attribut to true, but the "editing" state of component stay at false. (see screenshot)
I have tested with simple condition :
this.props.displayMode == DisplayMode.Edit
And state method, componentDidUpdate ... a lot of test.
Does anyone reproduce the problem?
Steps to Reproduce
Thanks
The text was updated successfully, but these errors were encountered: