-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FieldCollectionData enhancements #1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RicoNL , please review the requested change
src/controls/fieldCollectionData/collectionDataItem/CollectionDataItem.tsx
Outdated
Show resolved
Hide resolved
@RicoNL could you please also update the Test component to use the new options? |
@RicoNL many thanks! |
hi @joelfmrodrigues , I was working on the test component but I'm having difficulties to get the ControlsTest-webpart to work on my devtenant. This is the error message I'm having. Any ideas? |
@RicoNL Sorry I merged the PR, wasn't sure if you were still working on updates, but feel free to submit a separate PR. Regarding the error, I noticed that myself yesterday and I think it only happens when using fast-serve. Can you confirm that it works when using |
Thanks @joelfmrodrigues , that seems to work. I will create a new PR for the test component. |
@joelfmrodrigues PR for controlstest has been submitted: #1642 |
What's in this Pull Request?