Patch FieldCollectionData #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuidoZam many thanks for the updates. There was another PR to the same control that was created before this one and is now merged, adding two new types of controls: combobox and people picker. |
|
@joelfmrodrigues I'll check as soon as I can and let you know. |
joelfmrodrigues
added
status:working-on-it
|
@GuidoZam I ended up resolving the conflicts 🙂 no need to bother |
|
@GuidoZam many thanks for the new feature and also the fix. This is now merged into the dev branch |
joelfmrodrigues
removed
the
status:working-on-it
|
@joelfmrodrigues many thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Added a new implementation for a date field in the FieldCollectionData control.
It also fixes a UI wrong behavior for numeric value that occurs in the FieldCollectionData control when a numeric field is disabled: the input field seems to be editable but it is not.