Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy command #4933

Merged
merged 7 commits into from
Jun 27, 2022
Merged

feat: deploy command #4933

merged 7 commits into from
Jun 27, 2022

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jun 25, 2022

close #4378

@zkochan zkochan marked this pull request as ready for review June 26, 2022 23:45
@zkochan zkochan requested a review from a team June 26, 2022 23:46
@shellscape
Copy link
Contributor

Does this enable isolating workspace projects, negating the need for calling make-dedicated-lockfile manually?

@zkochan
Copy link
Member Author

zkochan commented Jun 27, 2022

Yes

@zkochan zkochan merged commit 7922d63 into main Jun 27, 2022
@zkochan zkochan deleted the feat/deploy branch June 27, 2022 16:58
@zkochan zkochan added this to the v7.4 milestone Jun 27, 2022
@DRoet
Copy link

DRoet commented Jun 27, 2022

Hi I played around using this in pnpm@7.4.0-3 and I have one question:

Would it be an idea to add a flag to include devDependencies in the dist or is there already a way to do this?

@zkochan
Copy link
Member Author

zkochan commented Jun 27, 2022

why do you need dev dependencies for runtime?

@shellscape
Copy link
Contributor

Probably better as a separate bug report for tracking. This is an opportunity to check for conflicting scripts and ask the user to remedy before continuing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A deploy command
4 participants