Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node<16 download fail on arm chips on macos #5239

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

ambar-arkin
Copy link
Contributor

@ambar-arkin ambar-arkin commented Aug 19, 2022

Add a check for macos apple silicon and required node version < 16.
In such case, download x64 binary.
Because arm build does not exist.
Macos automatically detects x64 instructions and converts them so downloaded node works as expected.
Previous behaviour:
Try to download non existing arm build and fail with 404.

NO breaking change
fixes #4489

@welcome
Copy link

welcome bot commented Aug 19, 2022

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@ambar-arkin
Copy link
Contributor Author

I am required to add copyright mark to files I modify when making work related opensource contributions.
If you have a different convention for marking files please let me know.

@ambar-arkin ambar-arkin marked this pull request as ready for review August 19, 2022 18:41
@zkochan
Copy link
Member

zkochan commented Aug 20, 2022

No, I don't think we will accept changes with license changes.

@ambar-arkin
Copy link
Contributor Author

@zkochan This is not a license change. The comment has same license as pnpm (MIT).
The LICENSE file already mentions copyright zoltan kochan and other contributors. VMware recommendation is to put the same copyright notice in individual files.

@zkochan
Copy link
Member

zkochan commented Aug 20, 2022

I am against this copyright notice. First of all, we don't put copyright notice to individual files. Secondly, this changes only 3 lines of code in a file edited by other contributors but you add a copyright notice of a company. This recommendation of VMware makes sense for open-source projects maintained by VMware but not in this case.

Add a check for macos apple silicon and required node version < 16.
In such case, download x64 binary.
Because arm build does not exist.
Previous behaviour:
Try to download non existing arm build and fail with 404.

NO breaking change
fixes pnpm#4489
@zkochan zkochan merged commit 1c7b439 into pnpm:main Aug 20, 2022
@welcome
Copy link

welcome bot commented Aug 20, 2022

Congrats on merging your first pull request! 🎉🎉🎉

This was referenced Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm env use --global 14 in M1
2 participants