Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(po-tab): ajustado traducao #1634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#tabDropdown
*ngIf="isShowTabDropdown"
class="po-tab-button po-tab-dropdown"
p-label="Mais"
[p-label]="literals.moreTabs"
[p-small]="small"
[p-tabs]="overflowedTabs"
(p-activated)="onTabActive($event)"
Expand Down
39 changes: 38 additions & 1 deletion projects/ui/src/lib/components/po-tabs/po-tabs.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ import * as UtilsFunction from './../../utils/util';

import { PoTabsComponent } from './po-tabs.component';
import { PoTabsModule } from './po-tabs.module';
import { PoLanguageService } from '../../services/po-language/po-language.service';

describe('PoTabsComponent:', () => {
let component: PoTabsComponent;
let fixture: ComponentFixture<PoTabsComponent>;
let nativeElement: any;
let poLanguageService: PoLanguageService;

let defaultTab;
let activeTab;
Expand All @@ -19,12 +21,15 @@ describe('PoTabsComponent:', () => {

configureTestSuite(() => {
TestBed.configureTestingModule({
imports: [PoTabsModule]
imports: [PoTabsModule],
providers: [PoLanguageService]
});
});

beforeEach(() => {
fixture = TestBed.createComponent(PoTabsComponent);
poLanguageService = TestBed.inject(PoLanguageService);

component = fixture.componentInstance;

defaultTab = { id: '1', active: false, label: 'Tab 1' };
Expand Down Expand Up @@ -244,6 +249,38 @@ describe('PoTabsComponent:', () => {

expect(component['activeFirstTab']).toHaveBeenCalled();
});

it('should display small tabs', () => {
component.tabs = <any>[{ id: '0' }, { id: '1' }, { id: '2' }, { id: '3' }, { id: '4' }, { id: '5' }];
component.small = true;
fixture.detectChanges();

const small = nativeElement.querySelector('.po-tab-button');

expect(small.getAttribute('ng-reflect-small')).toBeTruthy();
});

it('shouldn`t display small tabs', () => {
component.tabs = <any>[{ id: '0' }, { id: '1' }, { id: '2' }, { id: '3' }, { id: '4' }, { id: '5' }];
component.small = false;
fixture.detectChanges();

const small = nativeElement.querySelector('.po-tab-button');

expect(small.getAttribute('ng-reflect-small')).toBe('false');
});

it('should return correct language', () => {
spyOn(poLanguageService, 'getShortLanguage').and.returnValue('en');
component.setLanguage();
expect(component.literals.moreTabs).toEqual('More');
});

it('should return default language', () => {
spyOn(poLanguageService, 'getShortLanguage').and.returnValue('xx');
component.setLanguage();
expect(component.literals.moreTabs).toEqual('Mais');
});
});

describe('Templates:', () => {
Expand Down
31 changes: 30 additions & 1 deletion projects/ui/src/lib/components/po-tabs/po-tabs.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { isMobile } from './../../utils/util';
import { PoTabComponent } from './po-tab/po-tab.component';
import { PoTabDropdownComponent } from './po-tab-dropdown/po-tab-dropdown.component';
import { PoTabsBaseComponent } from './po-tabs-base.component';
import { PoLanguageService } from '../../services/po-language/po-language.service';
import { poLocaleDefault } from '../../services/po-language/po-language.constant';

const poTabsMaxNumberOfTabs = 5;

Expand Down Expand Up @@ -45,10 +47,30 @@ export class PoTabsComponent extends PoTabsBaseComponent {

maxNumberOfTabs = poTabsMaxNumberOfTabs;

poTabsLiterals = {
en: {
moreTabs: 'More'
},
pt: {
moreTabs: 'Mais'
},
es: {
moreTabs: 'Más'
},
rus: {
moreTabs: 'Ещё'
}
};

literals: {
moreTabs: string;
};

private previousActiveTab: PoTabComponent;

constructor(private changeDetector: ChangeDetectorRef) {
constructor(private changeDetector: ChangeDetectorRef, private languageService: PoLanguageService) {
super();
this.setLanguage();
}

get isMobileDevice() {
Expand All @@ -68,6 +90,13 @@ export class PoTabsComponent extends PoTabsBaseComponent {
return this.tabs.filter(tab => !tab.hide);
}

setLanguage(): void {
this.literals = {
...this.poTabsLiterals[poLocaleDefault],
...this.poTabsLiterals[this.languageService.getShortLanguage()]
};
}

closePopover(): void {
const containsPopoverVisible = this.tabDropdown && this.tabDropdown.popover && !this.tabDropdown.popover.isHidden;

Expand Down