Add option to hide OSD message #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to hide the text that shows up whenever a sponsoblock action has been triggered, a function has been added, that returns an empty string whenever the option "osd_text_show" is set to false see issue po5#44
dariusjonda
force-pushed
the
feature/hide-osd-message
branch
from
38aaa36
to
ec4444c
Compare
|
This is a bad hack that will display empty messages instead of nothing at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referring to the feature request in issue #44 I've added the
osd_text_showoption to choose whether to show the OSD message or not whenever a SponsorBlock action is being triggered.The function
osd_show()has been added to return the actual SponsorBlock text in caseost_text_show = trueand an empty string when set to false.I've never done anything in Lua before, therefore my simple solution might not be the most elegant one.
However I hope this is kinda helpful...