Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local docker compose initial version #33

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add local docker compose initial version #33

wants to merge 1 commit into from

Conversation

mlazowik
Copy link
Member

No description provided.

@mlazowik mlazowik requested review from annkamsk and micorix April 16, 2021 21:01
@mlazowik
Copy link
Member Author

This definitely still needs more work for better local dev experience, but this change should work by itself

@micorix
Copy link
Member

micorix commented Apr 16, 2021 •
edited
Loading

🎉 🎉 🎉

Can you update the readme pls?

  • The link to docker-compose still points to infra repo (and is broken btw). Can we also state clearly that this file is for dev purposes only and prod-ready file is in infra repo?
  • What about the case when someone wants to develop back-end AND front-end? (Just run docker-compose up in BE repo & yarn start in FE repo? If so, can we write it down 🙂)

annkamsk
annkamsk requested changes Apr 17, 2021
View reviewed changes
Copy link
Member

@annkamsk annkamsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README please :)

@mlazowik mlazowik marked this pull request as draft April 17, 2021 12:09
@micorix micorix removed their request for review January 9, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annkamsk annkamsk annkamsk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlazowik @micorix @annkamsk