Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix e2e for firefox #109

Merged
merged 5 commits into from
Sep 7, 2018
Merged

fix e2e for firefox #109

merged 5 commits into from
Sep 7, 2018

Conversation

dennis00010011b
Copy link

@dennis00010011b dennis00010011b commented Sep 7, 2018 •
edited by vbaranov
Loading

Relates to #105

Reasons why e2e test was unstable for firefox:

  1. selenium issue with method click() Selenium Click functionality does not work consistently SeleniumHQ/selenium#4075
  2. button 'Change password' is invisible in FF without scrolling down

It fixed now:

  1. used sendKeys(Key.RETURN) instead click()
  2. added scrolling down for screen 'Change password'

@ghost ghost assigned dennis00010011b Sep 7, 2018
@ghost ghost added the in progress label Sep 7, 2018
@vbaranov vbaranov merged commit 7e4b5f0 into poanetwork:validate-rpc Sep 7, 2018
@ghost ghost removed the in progress label Sep 7, 2018
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

Assignees

@dennis00010011b dennis00010011b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennis00010011b @vbaranov