Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Support POA network #12

Merged
merged 11 commits into from
Jul 19, 2018
Merged

(Feature) Support POA network #12

merged 11 commits into from
Jul 19, 2018

Conversation

fvictorio
Copy link

@fvictorio fvictorio commented Jul 19, 2018 •
edited
Loading

Closes #2.

This PR:

  • Adds support for POA Network
  • Uses it by default (when installing the extension, not when using unpacked)
  • Make it the first item in the list
  • Uses the POA explorer for showing accounts and transactions
  • Uses POA as symbol instead of ETH

@fvictorio
Add POA network
ec97f65
@fvictorio
Add locales for POA
7cbeff4
@fvictorio
Make POA the default network
861f056 
This makes POA the default network when the extension is installed. When
used as an unpacked extension (test mode) it won't be used.
@ghost ghost assigned fvictorio Jul 19, 2018
@ghost ghost added the in progress label Jul 19, 2018
@fvictorio fvictorio mentioned this pull request Jul 19, 2018
Merged
@patitonar patitonar mentioned this pull request Jul 19, 2018
Merged
vbaranov
vbaranov reviewed Jul 19, 2018
View reviewed changes
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-07-19 at 23 00 41

@fvictorio Maybe, let's rename button to POA Network ?

@fvictorio
Copy link
Author

@vbaranov Sure.

@vbaranov
Copy link
Collaborator

@fvictorio and also, let's change "BUY ETH" to "BUY POA" in case of POA

@fvictorio
Copy link
Author

@fvictorio and also, let's change "BUY ETH" to "BUY POA" in case of POA

Done.

@vbaranov
Copy link
Collaborator

@fvictorio I still see the button name "POA NETWORK TEST FAUCET" for core network

@fvictorio
Copy link
Author

Oh, sorry, I changed the "BUY ETH" title to "BUY POA", not the button. I'll change that too.

@fvictorio
Copy link
Author

@vbaranov Done.

@vbaranov vbaranov self-requested a review July 19, 2018 20:52
@vbaranov vbaranov merged commit fe2af9b into develop Jul 19, 2018
@ghost ghost removed the awaiting for review label Jul 19, 2018
@vbaranov vbaranov deleted the support-poa-network-#2 branch July 19, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@vbaranov vbaranov vbaranov approved these changes

Assignees

@fvictorio fvictorio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvictorio @vbaranov @patitonar