Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If a dapp has multiple watchers of different smart-contracts events, and one of them is fired, dapp gets multiple firings from the wallet. The number of firings is equal the number of watchers, that dapp has.
Solution: Filter events to emit. If an event has been emitted before, do not emit the same event once more.
Related change in
eth-json-rpc-filters
dependency poanetwork/eth-json-rpc-filters@22d40abThe behaviour could be tested with https://vbaranov.github.io/event-listener-dapp/:
The current release will fire 2 events.
The build from this PR will fire a single event.
@dennis00010011b could we add this test scenario with visiting the above link to our e2e tests?