Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) e.trim is not a function #204

Merged
merged 3 commits into from
Nov 26, 2018
Merged

(Fix) e.trim is not a function #204

merged 3 commits into from
Nov 26, 2018

Conversation

vbaranov
Copy link
Collaborator

screen shot 2018-11-23 at 16 04 05

@ghost ghost assigned vbaranov Nov 23, 2018
@ghost ghost added the in progress label Nov 23, 2018
@vbaranov vbaranov added this to the NW release 4.9.0 milestone Nov 23, 2018
@dennis00010011b
Copy link

@vbaranov
Failed to add custom tokens with decimals=0
View 'Add token' : buton 'Add' is disabled if decimals =0
https://8594-141182735-gh.circle-artifacts.com/0/test-artifacts/firefox/checks%20the%20token%20balance/test-failure-screenshot.png

@vbaranov
Copy link
Collaborator Author

@dennis00010011b Thanks! fixed 0fce30d

@vbaranov vbaranov merged commit 1be5b08 into develop Nov 26, 2018
@ghost ghost removed the awaiting for review label Nov 26, 2018
@vbaranov vbaranov deleted the trim-is-not-a-function-fix branch November 26, 2018 18:27
@vbaranov vbaranov mentioned this pull request Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis00010011b dennis00010011b dennis00010011b approved these changes

@patitonar patitonar patitonar approved these changes

@fvictorio fvictorio fvictorio approved these changes

Assignees

@vbaranov vbaranov

Labels
None yet
Projects
None yet
Milestone
NW release 4.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vbaranov @dennis00010011b @fvictorio @patitonar