forked from MetaMask/metamask-extension
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) Reorder contract executors: owners are first #239
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5d74c17
Reorder method executors: owners are first
vbaranov f3dd598
eslinter, unit tests fixes
vbaranov a44824a
Merge remote-tracking branch 'origin/develop' into contract-executors…
vbaranov 1314294
Merge remote-tracking branch 'origin/develop' into contract-executors…
vbaranov 291089d
empty owners var fix
vbaranov 418efd3
e2e:merge with PR#238-unlock back contract account
dennis00010011b cf9b333
e2e: check order in executor list
dennis00010011b 606a519
Merge pull request #242 from dennis00010011b/e2e-owners-first
vbaranov 5a87cfe
merge with develop branch
vbaranov c17261c
Updated e2e from Dennis
vbaranov ced7fd1
Merge branch 'develop' into contract-executors-reorder
vbaranov 0b2fb88
catch in getAllOwners
vbaranov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May it be possible to add a
catch
to the promise so you can callhideLoadingIndicator
if for any reason thePromise.all
fails?or you can refactor to use
async/await
s? whatever fits best.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fernandomg! Catch was added.