Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-page provider (EIP-1193) #342

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Conversation

vbaranov
Copy link
Collaborator

#217
#325
Continuation of #340

  • ethereum object extended with selectedAddress, networkVersion, chainId properties
  • _state object extended with isConnnected, isUnlocked properties
  • the provider emits chainChanged on connect to a new chain
  • the provider emits close on disconnect from a network
  • the provider emits connect on connect to a network
  • all subscriptions from the node emit on notification

In overall, the current Nifty Wallet in-page provider should coincide MetaMask's 7.7.8 in-page provider

@vbaranov vbaranov merged commit 8a04cd5 into develop Mar 31, 2020
@vbaranov vbaranov deleted the update-inpage-provider branch March 31, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant