Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Force open notification popup #94

Merged
merged 5 commits into from
Aug 27, 2018
Merged

(Fix) Force open notification popup #94

merged 5 commits into from
Aug 27, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #19

  • Force focus to notification popup if it is already opened because it can be hidden behind the DApp
  • Close notification window if action was confirmed in the popup or from notification window itself
  • Close notification window if all transactions were rejected at once from the popup or from notification window itself.

@ghost ghost assigned vbaranov Aug 23, 2018
@ghost ghost added the in progress label Aug 23, 2018
@ghost ghost assigned fvictorio Aug 27, 2018
@vbaranov vbaranov merged commit eb36612 into develop Aug 27, 2018
@ghost ghost removed the awaiting for review label Aug 27, 2018
@vbaranov vbaranov deleted the hidden-popup branch August 27, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio approved these changes

@patitonar patitonar patitonar approved these changes

Assignees

@fvictorio fvictorio

@vbaranov vbaranov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbaranov @fvictorio @patitonar