Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a 2/3 instead of 1/2 majority in Aura. #132

Merged
merged 4 commits into from
May 9, 2019

Conversation

afck
Copy link
Collaborator

@afck afck commented May 7, 2019

No description provided.

@afck afck requested review from vkomenda and varasev May 7, 2019 10:09
Copy link

@varasev varasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retested this PR: the problem seems to be in upstream stable branch with debug mode (when we build with cargo build). When I try to build the stable branch with cargo build --release --features final, I don't see the error.

Copy link

@varasev varasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine if we build it in release mode with cargo build --release --features final.

When building with cargo build (in debug mode), there are 6-second blocks because the second validator doesn't produce blocks for some reason. The bug can be seen with https://github.com/varasev/test-block-reward/tree/debug-mode-test

Seems this bug is not related to this modification because it's also observed for the upstream Parity v2.4.5 stable branch. Created an issue there: openethereum#10637

@varasev
Copy link

varasev commented May 8, 2019

@vkomenda @afck What is the cli option to launch original Parity unit tests?

@vkomenda
Copy link

vkomenda commented May 8, 2019

@varasev, change directory to ethcore and run cargo test.

@varasev
Copy link

varasev commented May 8, 2019

change directory to ethcore and run cargo test.

OK: test result: ok. 290 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out 👍

@vkomenda vkomenda merged commit 94e3bf7 into vk-stable-mulmod May 9, 2019
@afck afck deleted the afck-supermajority-stable-mulmod branch May 9, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants