-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a 2/3 instead of 1/2 majority in Aura. #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retested this PR: the problem seems to be in upstream stable
branch with debug
mode (when we build with cargo build
). When I try to build the stable
branch with cargo build --release --features final
, I don't see the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine if we build it in release mode with cargo build --release --features final
.
When building with cargo build
(in debug mode), there are 6-second blocks because the second validator doesn't produce blocks for some reason. The bug can be seen with https://github.com/varasev/test-block-reward/tree/debug-mode-test
Seems this bug is not related to this modification because it's also observed for the upstream Parity v2.4.5 stable
branch. Created an issue there: openethereum#10637
@varasev, change directory to |
OK: |
No description provided.