Audit fixes #3
Merged
Audit fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maxaleks
commented
Apr 30, 2020
maxaleks
commented
- locked pragma
- added dependency information to readme
- improved validation of min and max deposits
- improved validation of prize sizes
- improved validation of round duration
varasev
reviewed
Apr 30, 2020
contracts/PoaMania.sol
Outdated
| require(_roundDuration > 0, "should be greater than 0"); | ||
| uint256 randomUpdateInterval = random.getUpdateInterval(); | ||
| require( | ||
| _roundDuration > randomUpdateInterval.mul(4).mul(blockTime) && _roundDuration > blockTime.mul(40), |
There was a problem hiding this comment.
Let's move randomUpdateInterval.mul(2).mul(blockTime) to a private function and use such a function in _setRoundDuration() and in getLockStart().
How did you get 40 blocks? Why 40 exactly?
There was a problem hiding this comment.
Why 40 exactly?
It's just the length of one random collection round. What value do you suggest?
There was a problem hiding this comment.
Ok, let's maybe change this part of condition to _roundDuration > blockTime.mul(randomUpdateInterval) since randomUpdateInterval is the collection round length?
There was a problem hiding this comment.
It's only for the case when randomUpdateInterval is 0. But as you said me randomUpdateInterval can't be changed, so I'll just remove this check
varasev
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.