Aeris/Xweather unavailable fixes #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uajqq
force-pushed
the
aeris_unavailable_fix
branch
from
5af3433 to
139c74e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #904 and #959, both errors related to Aeris/Xweather. I have no idea why the diff looks so insane -- if you know how to fix this please tell me -- but all I did is wrap the entire forecast block in a
tryblock, so exceptions can be handled gracefully and rendering can continue if any step fails. I also added a block (line 1412) that specifically catches the IOError that only happens on the first time the skin is run, so an informational message can be logged instead.