Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTPClientSession: replace bare newlines in message content with CRLF. #4689

Closed
obiltschnig opened this issue Sep 13, 2024 · 0 comments
Closed
Assignees

Comments

@obiltschnig
Copy link
Member

Since SMTP servers (specifically, Postfix since early 2024) are increasingly rejecting emails containing bare newlines in their content (which is not valid in SMTP) due to potential SMTP smuggling attacks, its worth discussing whether SMTPClientSession should automatically normalize all bare linefeeds in messages to CRLF sequences.

The proper place for this fix would be in the MailOutputStream class, which already deals with CRLF sequences.

@obiltschnig obiltschnig added this to the Release 1.14.0 milestone Sep 13, 2024
@obiltschnig obiltschnig self-assigned this Sep 13, 2024
@obiltschnig obiltschnig added this to 1.14 Sep 26, 2024
@obiltschnig obiltschnig moved this to In Progress in 1.14 Sep 26, 2024
@obiltschnig obiltschnig moved this from In Progress to Done in 1.14 Sep 26, 2024
@matejk matejk closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants