Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable Isolation level for SQLite Databases #4693

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Sep 15, 2024

No description provided.

bas524 and others added 3 commits June 7, 2024 15:58
I've add transaction isolation support for SQLite
Warning! SQLite transactions are [serializable by design](https://
www.sqlite.org/isolation.html) but my implementation retuns false in
function hasTransactionIsolation and throw an exception in
setTransactionIsolation
@aleks-f aleks-f linked an issue Sep 15, 2024 that may be closed by this pull request
@aleks-f aleks-f added this to the Release 1.14.0 milestone Sep 15, 2024
@aleks-f aleks-f changed the title Sqlite.isolation Serializable Isolation level for SQLite Databases Sep 15, 2024
Data/SQLite/src/SessionImpl.cpp Dismissed Show dismissed Hide dismissed
Data/SQLite/src/SessionImpl.cpp Dismissed Show dismissed Hide dismissed
Copy link
Member Author

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bas524 tests are failing on mac

@bas524
Copy link
Contributor

bas524 commented Sep 25, 2024

@bas524 tests are failing on mac

Hi!
I can't reproduce problem on my mac.
I'll try to find another for test

@bas524
Copy link
Contributor

bas524 commented Oct 1, 2024

@bas524 tests are failing on mac

@aleks-f , Hi!
I've fixed the problem into PR #4718
Could you re-run the merging ?

@aleks-f aleks-f merged commit 88c4958 into main Oct 10, 2024
42 checks passed
@aleks-f aleks-f deleted the sqlite.isolation branch October 10, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Serializable Isolation level for SQLite Databases
2 participants