Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.15.1 #166

Merged
merged 25 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7605599
initial implementaiton of subset code
mike-gangl Mar 16, 2023
c69ed98
added tests, more updates
mike-gangl Mar 22, 2023
65737b9
removed skip_errors (not implemented yet)
mike-gangl Mar 30, 2023
ba90bd1
Upgrade to harmony-py 0.4.9
skorper Aug 4, 2023
13b9ece
subsetting capability initial commit
skorper Aug 4, 2023
658ba05
update spacing
skorper Aug 4, 2023
c27363c
Merge remote-tracking branch 'origin' into issues/36
skorper Aug 4, 2023
364dc40
Update docs
skorper Aug 7, 2023
0b30966
update poetry lock
skorper Aug 18, 2023
c9513c5
upgrade to poetry 1.5.1 (latest)
skorper Aug 18, 2023
3decb92
fix failing checksum test
skorper Aug 18, 2023
285970b
fixed regression test issues
skorper Aug 18, 2023
d5dccea
bump poetry version in second gh action file
skorper Aug 21, 2023
ceceae8
Update poetry version to fix build issue
skorper Aug 21, 2023
6319250
bump poetry version
skorper Aug 22, 2023
12ca7b4
bump poetry version
skorper Aug 22, 2023
2e4565b
Merge pull request #142 from podaac/issues/36
skorper Aug 22, 2023
cd217eb
bump version to 1.15.0
skorper Aug 22, 2023
7c12601
bump version to 1.15.0
skorper Aug 22, 2023
82e6896
Merge remote-tracking branch 'origin' into develop
skorper Feb 5, 2024
c855903
add unreleased section to changelog
skorper Feb 5, 2024
9782d1f
issue/161: Fix bug where --subset flag fails with data subscriber (#162)
skorper Mar 7, 2024
080987e
bump version
skorper Mar 7, 2024
4528e6e
bump version
skorper Mar 7, 2024
e5f8205
Issue/164: Upgrade harmony-py to avoid 413 request entity too large i…
skorper Mar 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [1.15.1]
### Fixed
- Fixed bug where --subset in combination with the subscriber caused errors
### Added

## [1.15.0]
### Added
- Added support for Harmony subsetting
Expand Down
27 changes: 13 additions & 14 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "podaac-data-subscriber"
version = "1.15.0"
version = "1.15.1-alpha.2"
description = "PO.DAAC Data Subscriber Command Line Tool"
authors = ["PO.DAAC <podaac@podaac.jpl.nasa.gov>"]
readme = "README.md"
Expand All @@ -16,7 +16,7 @@ python = "^3.7"
requests = "^2.27.1"
tenacity = "^8.0.1"
packaging = "^23.0"
harmony-py = "^0.4.9"
harmony-py = "^0.4.12"

[tool.poetry.dev-dependencies]
pytest = "^7.1.2"
Expand Down
9 changes: 1 addition & 8 deletions subscriber/podaac_access.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import tenacity
from datetime import datetime

__version__ = "1.15.0"
__version__ = "1.15.1"
extensions = ["\\.nc", "\\.h5", "\\.zip", "\\.tar.gz", "\\.tiff"]
edl = "urs.earthdata.nasa.gov"
cmr = "cmr.earthdata.nasa.gov"
Expand Down Expand Up @@ -221,13 +221,6 @@ def validate(args):
'Please specify exactly one flag '
'from -dc, -dy, -dydoy, or -dymd')

if args.subset and args.search_cycles:
# Cycle+Subset are not supported, because Harmony does not
# currently accept Cycle.
raise ValueError(
'Error: Incompatible Parameters. You\'ve provided both cycles and subset, which is '
'not allowed. Please provide either cycles or subset separately, but not both.')

if args.subset and args.bbox:
bounds = list(map(float, args.bbox.split(',')))
if bounds[0] > bounds[2]:
Expand Down
7 changes: 7 additions & 0 deletions subscriber/podaac_data_downloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ def validate(args):
if None in [args.endDate, args.startDate] and args.search_cycles is None and args.granulename is None:
raise ValueError(
"Error parsing command line arguments: Both --start-date and --end-date must be specified") # noqa E50
if args.subset and args.search_cycles:
# Cycle+Subset are not supported, because Harmony does not
# currently accept Cycle.
raise ValueError(
'Error: Incompatible Parameters. You\'ve provided both cycles and subset, which is '
'not allowed. Please provide either cycles or subset separately, but not both.'
)


def create_parser():
Expand Down
Loading