New Forge Algorithms #30
Conversation
sliu008
commented
Nov 18, 2024
sliu008
commented
- Added a new bin average method for thinning
- Added open cv strategy to generating footprint
- Added License
- Update way configuration structure are for forge-py
- Update documentations
README.md
Outdated
| "simplify":0.3, | ||
| "min_area": 30, | ||
| "fill_kernel": [30,30], | ||
| "group": "group for lon lat" |
There was a problem hiding this comment.
Let's get rid of these groups and put them in the latVar, lonVar, and timeVar.
Same for in alpha_shape
| ] | ||
| "footprint":{ | ||
| "strategy":"alpha_shape", | ||
| "alpha_shape":{ |
There was a problem hiding this comment.
Update this example file
podaac/forge_py/forge.py
Outdated
|
|
||
| wkt_alphashape = dumps(alpha_shape) | ||
| return wkt_alphashape | ||
| return dumps(footprint, trim=True) | ||
|
|
||
|
|
||
| def fit_footprint( |
There was a problem hiding this comment.
This is only for alpha_shape right? Can you move all the alpha_shape strategy to a new file? And keep the forge.py small and simple. Maybe you can create a new subdir with strategy and then put the open_cv_footprint.py and the alpha_shape_footprint.py in there to keep it more organized. Sound good?
| @@ -8,6 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - Updated alpha shape algorithm with bin average thinning | |||
There was a problem hiding this comment.
Update this with the new suggestions too
README.md
Outdated
| ## Configuration Options | ||
|
|
||
| ### `footprint` | ||
| * **`lonVar`** (string, required): Longitude variable in the dataset. |
There was a problem hiding this comment.
Add that group is supported and give an example
README.md
Outdated
| * **`pixel_height`** (int, optional, default: 1800): Desired pixel height for the input image. | ||
| * **`min_area`** (int, optional): Minimum area for polygons to be retained. | ||
| * **`fill_kernel`** (list of int, optional, default: [20,20]): Kernel size for filling holes in polygons. | ||
| * **`group`** (string, optional): NetCDF file group to use for input data for lon lat. |
README.md
Outdated
| * **`value`** (list of float or float): Thinning parameters. | ||
| * **`cutoff_lat`** (int, optional): Latitude cutoff for smoothing. | ||
| * **`smooth_poles`** (list of int, optional): Latitude range for smoothing near poles. | ||
| * **`group`** (string, optional): NetCDF file group to use for input data for lon lat. |
README.md
Outdated
| "thinning": {"method": "bin_avg", "value": [0.5, 0.5]}, | ||
| "cutoff_lat": 80, | ||
| "smooth_poles": [78,80], | ||
| "group": "group for lon lat", |
podaac/forge_py/forge.py
Outdated
| return strategy, {**common_params, **strategy_params} | ||
|
|
||
|
|
||
| def thinning_bin_avg(x, y, rx, ry): |
There was a problem hiding this comment.
move to their specific file in the strategy, e.g. alpha_shape
| return xy_thinned["x"].values, xy_thinned["y"].values | ||
|
|
||
|
|
||
| def remove_small_polygons(geometry, min_area): |
There was a problem hiding this comment.
move to open_cv file, unless it's used by both? is it?
| "strategy":"alpha_shape", | ||
| "alpha_shape":{ | ||
| "thinning":{ | ||
| "method":"standard", |
There was a problem hiding this comment.
This needs updating
"thinning": {"method": "bin_avg", "value": [0.5, 0.5]},
There was a problem hiding this comment.
does it work with one value and not an array?
| "strategy":"alpha_shape", | ||
| "alpha_shape":{ | ||
| "thinning":{ | ||
| "method":"standard", |
| "strategy":"alpha_shape", | ||
| "alpha_shape":{ | ||
| "thinning":{ | ||
| "method":"standard", |
There was a problem hiding this comment.
does it work with one value and not an array?
