Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node versions and dependencies #260

Merged
merged 1 commit into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: npm install
run: |
npm install
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: npm install
run: |
npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [12.x, 14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ coverage/
node_modules/
*.log
.vscode
.tap
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"scripts": {
"lint": "eslint .",
"lint:fix": "eslint --fix .",
"test": "tap tests/*.js"
"test": "tap tests/*.js --disable-coverage --allow-empty-coverage"
},
"dependencies": {
"@metrics/client": "2.5.2",
Expand All @@ -51,12 +51,12 @@
"@semantic-release/release-notes-generator": "12.1.0",
"semantic-release": "22.0.8",
"@podium/test-utils": "2.5.2",
"eslint": "8.52.0",
"eslint": "8.54.0",
"eslint-config-airbnb-base": "15.0.0",
"eslint-config-prettier": "8.10.0",
"eslint-config-prettier": "9.0.0",
"eslint-plugin-import": "2.29.0",
"eslint-plugin-prettier": "4.2.1",
"prettier": "2.8.8",
"tap": "14.11.0"
"eslint-plugin-prettier": "5.0.1",
"prettier": "3.1.0",
"tap": "18.6.1"
}
}
5 changes: 1 addition & 4 deletions tests/proxying.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,7 @@ class ProxyServer {
listen() {
return new Promise((resolve) => {
this.server = this.app.listen(0, 'localhost', () => {
this.address = `http://${this.server.address().address}:${
this.server.address().port
}`;

this.address = `http://localhost:${this.server.address().port}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.server.address() was returning an ipv6 address which caused everything else to bork

resolve(this.address);
});
});
Expand Down