refactor: adding a check for the KUBECONFIG variable #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexonOliveiraRH
requested review from
cdrage and
axel7083
and removed request for
a team
This validation of the existence of the KUBECONFIG variable set in the operating system aims to inform the use through the console that this could lead to an unexpected behavior in some scenarios, like trying to install a Kubernetes cluster and failing because Podman Desktop cannot use or update the default ~/.kube/config file. The issue podman-desktop#9983 describes this better with an example of such situation. Although this not correct the variable value, at least informs the user of its value, allowing the user to take the proper action to fix it. Closes podman-desktop#9983 Signed-off-by: Alexon Oliveira <alexon@redhat.com> Signed-off-by: Alexon Oliveira <alolivei@redhat.com>
AlexonOliveiraRH
force-pushed
the
fixissue9983
branch
from
f3423f8 to
5b8ed57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexon Oliveira alexon@redhat.com
What does this PR do?
This validation of the existence of the KUBECONFIG variable set in the operating system aims to inform the use through the console that this could lead to an unexpected behavior in some scenarios, like trying to install a Kubernetes cluster and failing because Podman Desktop cannot use or update the default ~/.kube/config file. Although this not correct the variable value, at least informs the user of its value, allowing the user to take the proper action to fix it.
Screenshot / video of UI
What issues does this PR fix or reference?
The issue #9983 describes this better with an example of such situation. Closes #9983.
How to test this PR?