fix: add implementation for compose update #9402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
dgolovin
requested review from
cdrage,
feloy and
axel7083
and removed request for
a team
benoitf
approved these changes
Oct 16, 2024
feloy
approved these changes
Oct 16, 2024
axel7083
reviewed
Oct 16, 2024
| @@ -44,7 +44,7 @@ export function getSystemBinaryPath(binaryName: string): string { | |||
| } | |||
|
|
|||
| // Takes a binary path (e.g. /tmp/docker-compose) and installs it to the system. Renames it based on binaryName | |||
| export async function installBinaryToSystem(binaryPath: string, binaryName: string): Promise<void> { | |||
| export async function installBinaryToSystem(binaryPath: string, binaryName: string): Promise<string | undefined> { | |||
There was a problem hiding this comment.
should not be Promise<string | undefined> the signature should always return a string, if the function was not able to install system-wide (user cancel, or refuse to give admin privilege) it should throw an error
There was a problem hiding this comment.
@axel7083 I'll open follow up on this, because I don't want add too much new functionality to the fix.
axel7083
reviewed
Oct 16, 2024
| await composeDownload.download(releaseToUpdateTo); | ||
| // get the binary in the extension folder | ||
| const storagePath = await detect.getStoragePath(); | ||
| binaryPath = await installBinaryToSystem(storagePath, composeCliName); |
There was a problem hiding this comment.
try {
// try to install system wide
} catch {
// log the error
} finally {
// update the composeCliTool with either the path from the extension folder or the system wide if install success
}
There was a problem hiding this comment.
Same as previous comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements update support for compose CLI
Screenshot / video of UI
What issues does this PR fix or reference?
Fix #8838.
How to test this PR?